Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --signature option to remove & filter #484

Merged
merged 7 commits into from
Jun 27, 2019

Conversation

beckyjackson
Copy link
Contributor

See proposal at #483

Currently implemented as --signature <true/false> (-S <true/false>) but this can easily be changed. This works with --trim, for example:

filter --trim false --signature true

Returns all axioms that have at least one target entity in their signature. Alternatively:

filter --trim true --signature true

Returns all axioms that have signatures containing only the entities in the target set.

remove --trim false --signature true

Removes all axioms that have signatures containing only the entities in the target set. Alternatively:

remove --trim true --signature true

Removes all axioms that have at least one target entity in their signature.

The default behavior is --signature false.

@jamesaoverton
Copy link
Member

Updated based on discussions from yesterday. As always, it was not as straightforward as I had hoped. I still need to update documentation.

@jamesaoverton jamesaoverton changed the title [WIP] Add --signature option to remove & filter Add --signature option to remove & filter Jun 27, 2019
@jamesaoverton
Copy link
Member

I think that the new --signature true option is behaving as designed. I've updated almost all the integration tests / examples to use --signature true and they pass. I've updated the docs to reflect the discussion in #483.

I'm going to merge this and make a release. Then we'll see what the next set of problems is.

@jamesaoverton jamesaoverton merged commit 5b25238 into ontodev:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants