Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maven plugin to update OBO context #608

Merged
merged 4 commits into from
Feb 7, 2020
Merged

Add maven plugin to update OBO context #608

merged 4 commits into from
Feb 7, 2020

Conversation

beckyjackson
Copy link
Contributor

See the README

We can add this to one of the default maven lifecycle phases, but I didn't want this to run every time we mvn clean package (in case somebody isn't connected to the internet).

Maybe mvn site? Or we can just run this every so often with mvn robot:UpdateContext -N...

@jamesaoverton
Copy link
Member

This is cool!

I'm worried that some prefixes are being dropped from the context file. Can you please do some investigating?

@beckyjackson
Copy link
Contributor Author

beckyjackson commented Jan 21, 2020

I'm not sure where this file originally came from, but I took a look at the original obo_context.jsonld file from the OBO Foundry repo and most of these are how they were in that file. Most of them are just changes to uppercase -

ExO -> EXO
FBsp -> FBSP
LiPrO -> LIPRO
miRNAO -> MIRNAO
NIF_Cell -> NIF_CELL
NIF_Dysfunction -> NIF_DYSFUNCTION
VariO -> VARIO
vHOG -> VHOG
WBls -> WBLS

NCIT is a kind of major change, but I don't think I've seen the prefix ncithesaurus used:
ncithesaurus -> NCIT

The only truly missing one is uberon-basic, but I can't figure out where that originally came from.

@jamesaoverton
Copy link
Member

Ok, so nothing important was dropped. But I'm still a bit worried about breaking pipelines when these prefixes change.

@cmungall What do you think of these prefix changes?

@cmungall
Copy link
Contributor

cmungall commented Feb 3, 2020

The only problematic one is WBls, which didn't have the preferred mixed-case prefix registered. I fixed this in the registry. You can hand-edit this one and merge this PR, or wait til the new prefixes file percolates through

@beckyjackson
Copy link
Contributor Author

I'll just change this line in the file:

"WBls": "http://purl.obolibrary.org/obo/WBls_"

cmungall added a commit to OBOFoundry/OBOFoundry.github.io that referenced this pull request Feb 3, 2020
This fixes WBls prefix, see ontodev/robot#608
@jamesaoverton jamesaoverton merged commit 7c00d09 into master Feb 7, 2020
@jamesaoverton jamesaoverton deleted the context branch March 2, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants