71 structure json schema files #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 2, 2017
spec/support/json_schema_matcher.rb
Outdated
| # finds the innermost context and transforms it from "GET show" to "get_show". | ||
| def normalized_context(example) | ||
| example_group = example.example_group | ||
| while (!(example_group.description =~ /\A(get|put|post|patch|delete)\s+/i)) |
There was a problem hiding this comment.
Style/NegatedWhile: Favor until over while for negative conditions.
Style/ParenthesesAroundCondition: Don't use parentheses around the condition of a while.
Style/RedundantParentheses: Don't use parentheses around an unary operation.
houndci-bot
reviewed
Feb 2, 2017
| end | ||
| it { expect(response).to have_http_status(:unauthorized) } | ||
| it do |example| |
There was a problem hiding this comment.
Style/IndentationConsistency: Inconsistent indentation detected.
houndci-bot
reviewed
Feb 2, 2017
| it do | ||
| expect(response).to match_response_schema('v2', 'organization_show') | ||
| end | ||
| it { |example| expect([example, response]).to comply_with_api('organizations/get_show') } |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [97/80]
houndci-bot
reviewed
Feb 2, 2017
| @@ -18,8 +18,7 @@ | |||
| context 'successful' do | |||
| before { get :show, params: {slug: subject.slug} } | |||
| it { expect(response).to have_http_status(:ok) } | |||
| it { expect(response).to match_response_schema('v2', 'jsonapi') } | |||
| it { expect(response).to match_response_schema('v2', 'user_show') } | |||
| it { |example| expect([example, response]).to comply_with_api('users/get_show') } | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [89/80]
eugenk
force-pushed
the
71-structure_json_schema_files
branch
from
df4a747
to
dba068d
Compare
ebolloff
suggested changes
Feb 20, 2017
spec/support/json_schema_matcher.rb
Outdated
| @@ -1,14 +1,56 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| RSpec::Matchers. | |||
| define :match_response_schema do |api_version, schema| | |||
| # Finds and ransforms constant V2::UsersController to string "v2/users". | |||
eugenk
force-pushed
the
71-structure_json_schema_files
branch
from
dba068d
to
591c5b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall fix #71.
It makes the structure also compatible with doca (see #61).