Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues #1

Merged
merged 1 commit into from Mar 25, 2022
Merged

Fix various issues #1

merged 1 commit into from Mar 25, 2022

Conversation

joachimvh
Copy link
Contributor

This was easier when I was looking at it anyway then explaining it over text 馃槈 . After this the server can be started with npx community-solid-server file-search.json or npm start (and with the -f flag if you want to choose the data folder).

Summary of some things:

  • The build command was missing a reference to the .componentsignore file. Was also missing the flag that made it so you can write "source" in the config instead of "SearchListener:_source" (last one is not needed anymore once we switch to components.js 5.x). It was also using a prefix that didn't match the repo.
  • The EventEmitter import was missing.
  • Moved the components.js SearchListener definition to a separate file so it can be imported by other configurations.
  • Fixed file-search.json with correct imports and contexts.
  • Fixed components.js URLs in package.json (only the major version number is used, rest needs to be 0).

@joepio joepio merged commit 4e612dd into ontola:master Mar 25, 2022
@joepio
Copy link
Member

joepio commented Mar 25, 2022

Thank you so much!

@joachimvh joachimvh deleted the fix branch March 25, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants