Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tolog: Why is QueryMatches initialSize not a constant? #506

Open
GoogleCodeExporter opened this issue Mar 16, 2015 · 3 comments
Open

tolog: Why is QueryMatches initialSize not a constant? #506

GoogleCodeExporter opened this issue Mar 16, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

<https://code.google.com/p/ontopia/source/browse/trunk/ontopia-engine/src/main/j
ava/net/ontopia/topicmaps/query/impl/basic/QueryMatches.java#43>

WTF? 

Some test cases rely on changing the value of initialSize which leads to 
errors, see my comment to issue #80.

If there is no good (*very* good) reason, initialSize should be made private 
static final

Original issue reported on code.google.com by lars.he...@gmail.com on 29 Sep 2014 at 5:23

@GoogleCodeExporter
Copy link
Author

We'll have to inspect the reason behind those testcases. There are many more 
places where fields should be final

Original comment by qsieb...@gmail.com on 29 Sep 2014 at 5:43

@GoogleCodeExporter
Copy link
Author

ACK.

Probably columnDefinitions and colCount should be changed to public *final*

Can you reopen issue #80 or should I create another issue for it?
C.f. <https://code.google.com/p/ontopia/issues/detail?id=80#c5>

Original comment by lars.he...@gmail.com on 29 Sep 2014 at 6:32

@GoogleCodeExporter
Copy link
Author

Will do tomorrow

Original comment by qsieb...@gmail.com on 29 Sep 2014 at 6:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant