Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): add o-alert component #32

Merged
merged 10 commits into from
Sep 1, 2022
Merged

feat(component): add o-alert component #32

merged 10 commits into from
Sep 1, 2022

Conversation

yzh990918
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for idyllic-kitten-f7a0d0 ready!

Name Link
🔨 Latest commit 9ad09a5
🔍 Latest deploy log https://app.netlify.com/sites/idyllic-kitten-f7a0d0/deploys/630f3a3fede7ac00084b8975
😎 Deploy Preview https://deploy-preview-32--idyllic-kitten-f7a0d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zyyv zyyv self-requested a review August 31, 2022 08:43
@zyyv zyyv changed the title add o-alert component feat(component): add o-alert component Sep 1, 2022
@zyyv zyyv merged commit 2284516 into onu-ui:main Sep 1, 2022
@yzh990918 yzh990918 deleted the feat/alert branch September 1, 2022 01:47
@yzh990918
Copy link
Member Author

yzh990918 commented Sep 2, 2022

I found a strange problem 🤣, When I run pnpm build, I have exported the alert component and props, but the component declaration is not generated in the dist, After investigating for a long time, I finally located the emits here. If I delete the close event emits, it will be packaged successfully. It seems that I didn't find the problem with the code

I am a bit at a loss to solve this problem, you can pay attention to this problem when you have time 😄 @chris-zhu Thanks

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants