Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): @onu-ui path can not work normally #96

Merged
merged 10 commits into from
Nov 7, 2022
Merged

Conversation

yzh990918
Copy link
Member

@yzh990918 yzh990918 commented Nov 3, 2022

After publish,the dist file directory doesn't has the tsconfig.json, We should use the relative path @zyyv .
image

@yzh990918 yzh990918 requested a review from zyyv as a code owner November 3, 2022 12:30
@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for spectacular-wisp-fcff7b ready!

Name Link
🔨 Latest commit 5869862
🔍 Latest deploy log https://app.netlify.com/sites/spectacular-wisp-fcff7b/deploys/6363b467c2521600082f0215
😎 Deploy Preview https://deploy-preview-96--spectacular-wisp-fcff7b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for idyllic-kitten-f7a0d0 ready!

Name Link
🔨 Latest commit 5869862
🔍 Latest deploy log https://app.netlify.com/sites/idyllic-kitten-f7a0d0/deploys/6363b467a5e47a0009953a1a
😎 Deploy Preview https://deploy-preview-96--idyllic-kitten-f7a0d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yzh990918
Copy link
Member Author

yzh990918 commented Nov 3, 2022

After merge,try publish again.

@yzh990918 yzh990918 changed the title fix: @onu-ui path can not work normally fix(build): @onu-ui path can not work normally Nov 4, 2022
@yzh990918
Copy link
Member Author

Is there a better solution to this problem 😄 ? @zyyv

@zyyv
Copy link
Member

zyyv commented Nov 7, 2022

Try it.

@zyyv zyyv merged commit 9701504 into onu-ui:main Nov 7, 2022
@yzh990918
Copy link
Member Author

OK, try publish a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants