Translations from i18n/*.toml aren't respected in variables.js

[ltguillaume]

compose/assets/js/variables.js

Lines 33 to 44 in 3fc585d

	// defined in i18n / translation files
	const quick_links = '{{ T "quick_links" }}';
	const search_results_label = '{{ T "search_results_label" }}';
	const short_search_query = '{{ T "short_search_query" }}'
	const type_to_search = '{{ T "type_to_search" }}';
	const no_matches_found = '{{ T "no_matches" }}';
	const copy_text = '{{ T "copy" }}';
	const copied_text = '{{ T "copied" }}';
	const toggle_line_numbers_text = '{{ T "toggle_line_numbers" }}';
	const toggle_line_wrap_text = '{{ T "toggle_line_wrap" }}';
	const resize_snippet = '{{ T "resize_snippet" }}';
	const not_set = '{{ T "not_set" }}';

These all fall back to the default language (usually English), no matter if they have been translated in i18n/*.toml.

[onweru]

@ltguillaume, this is because the scripts partial is cached, I will fix it now.

[ltguillaume]

Aah, makes sense!

[onweru]

@ltguillaume, please test when you can if it's indeed fixed.

[ltguillaume]

Just updated to b6a8bb2 but it isn't working for me yet.

[onweru]

Thanks for the feedback @ltguillaume. I think my fix is a little flawed, will refine it.

[ltguillaume]

Thx. While you're diving into the rabbit hole called JavaScript anyway, perhaps a separation of scripts that have to be run asap (e.g. to fix #91) and those that can be bundled at the end of the page is in order?

[onweru]

Hi @ltguillaume, 64b50b6 should do it. Please check 🤞🏼

[ltguillaume]

Sorry, it's still all in English 🙈

[onweru]

@ltguillaume, can you remind me your repo URL? I need to test with that

[ltguillaume]

Sure! https://codeberg.org/joinjabber/website-hugo

[ltguillaume]

Didn't see the fix in poiu-de@02119b2 before, can confirm it works now. Thanks!