Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the repository structure into a monorepo #6

Merged
merged 17 commits into from
Oct 2, 2023

Conversation

ony3000
Copy link
Owner

@ony3000 ony3000 commented Oct 1, 2023

Before supporting integration with prettier v3, the repository structure is reorganized into a monorepo for the following reasons.

  • Unlike prettier-plugin-brace-style or prettier-plugin-classnames, v2-only and v3-only objects are not expected to share core parts of the printer.
  • While implementing integration with prettier v3 in prettier-plugin-brace-style and prettier-plugin-classnames, formatting failures due to prettier version conflicts often occurred, but I hope that it will be okay if it is a monorepo structure.
  • Implementing integration with prettier v3 in this plugin is expected to increase the complexity of testing, and reorganizing this repository into a monorepo seemed to save resources compared to operating a separate repository dedicated to testing.

(이하 구글 번역기에 넣고 돌린 한국어 원문)

prettier v3와의 통합을 지원하기에 앞서, 다음과 같은 이유로 저장소의 구조를 모노레포로 개편합니다.

  • prettier-plugin-brace-style이나 prettier-plugin-classnames와는 달리, v2 전용 객체와 v3 전용 객체가 프린터의 핵심 부분을 공유할 수 없을 것으로 예상됩니다.
  • prettier-plugin-brace-styleprettier-plugin-classnames에 prettier v3와의 통합을 구현하는 동안, prettier 버전 충돌로 인한 서식 지정 실패가 종종 발생했는데, 혹시 모노레포 구조라면 괜찮지 않을까 하는 기대가 있습니다.
  • 이 플러그인에 prettier v3와의 통합을 구현하면 테스트의 복잡도가 증가할 것으로 예상되는데, 이 저장소를 모노레포로 개편하는 것이 테스트 전용의 별도 저장소를 운영하는 것보다 리소스가 절약될 수 있을 것 같았습니다.

@ony3000 ony3000 self-assigned this Oct 1, 2023
@ony3000 ony3000 marked this pull request as ready for review October 2, 2023 06:56
@ony3000 ony3000 merged commit 17b94f0 into master Oct 2, 2023
@ony3000 ony3000 deleted the reorganize-repository-structure branch October 2, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant