Handle placeholder generation #33

luqmanoop · 2018-10-22T17:23:14Z

What does this PR do?

Fixes a bug where a placeholder is being generated for wrong src assumed to be a Cloudinary image.

How to test this PR?

/*
* Before
* Given an image with src other than Cloudinary
* https://cdn.pexels.com/upload/2012/02/10/cloudinary__340.jpg
*/
if (src && src.includes('cloudinary')) { // matches
  ...
}

As stated in Cloudinary documentation here, the best way to test if the image is from Cloudinary is to check in the host

/*
* After
* Given an image with src other than Cloudinary
* https://cdn.pexels.com/upload/2012/02/10/cloudinary__340.jpg
*/
try {
  const srcURL = new URL(src)
  if (srcURL.host.includes('cloudinary')) { // does not match
    ...
  }
} catch(err) {}

…dinary` match in image src - test for `cloudinary` match in image src host and properly generate placeholder for cloudinary images - update broken image src for react/preact in app examples - keep code DRY

ooade · 2018-10-22T17:55:35Z

Thanks. I'll look into this. It might take a while tho.

luqmanoop · 2018-11-03T11:45:10Z

Thanks for reviewing and merging. Cheers.

fix(cloudinary-placeholder): properly handle string replace for `clou…

595b8e2

…dinary` match in image src - test for `cloudinary` match in image src host and properly generate placeholder for cloudinary images - update broken image src for react/preact in app examples - keep code DRY

luqmanoop changed the title ~~properly handle string replace for `clou…~~ Handle placeholder generation Oct 22, 2018

ooade merged commit f475cca into master Nov 3, 2018

luqmanoop deleted the fix/cloudinary-placeholder branch November 3, 2018 11:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle placeholder generation #33

Handle placeholder generation #33

luqmanoop commented Oct 22, 2018 •

edited

Loading

ooade commented Oct 22, 2018

luqmanoop commented Nov 3, 2018

Handle placeholder generation #33

Handle placeholder generation #33

Conversation

luqmanoop commented Oct 22, 2018 • edited Loading

What does this PR do?

How to test this PR?

ooade commented Oct 22, 2018

luqmanoop commented Nov 3, 2018

luqmanoop commented Oct 22, 2018 •

edited

Loading