Switch to using clone element #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblevins1991
suggested changes
Jan 26, 2021
|
I will pull this branch later and test it. The code looks good so far. |
ooade
force-pushed
the
feature/use-clone-element
branch
from
c871efd
to
ce7d381
Compare
|
@jblevins1991 I've fixed most of your concerns. You can test and give feedback. I've published a beta package so you don't have to pull the repository to test. Thanks! |
ooade
force-pushed
the
feature/use-clone-element
branch
from
b187df9
to
068950d
Compare
I copied the code file into my project and tested it. Everything seemed to work well. I am going to approve the pull request. |
jblevins1991
approved these changes
Jan 29, 2021
ooade
added a commit
that referenced
this pull request
Feb 6, 2021
* Switch to using clone element (#28) * Switch to using clone element * Exclude children from interface * Add multiref * Bump rollup and add rollup-ts * Use ref from child component for click away * Remove usued package * alpha 6 * Restor peer dependencies * Add proper types and increase coverage * Ensure the ref is clickable * Update workflow name * Remove release file * fix: publish * perf: New release 🚀
ooade
added a commit
that referenced
this pull request
Feb 6, 2021
* Switch to using clone element (#28) * Switch to using clone element * Exclude children from interface * Add multiref * Bump rollup and add rollup-ts * Use ref from child component for click away * Remove usued package * alpha 6 * Restor peer dependencies * Add proper types and increase coverage * Ensure the ref is clickable * Update workflow name * Remove release file * fix: publish * perf: New release 🚀
ooade
added a commit
that referenced
this pull request
Feb 6, 2021
* Switch to using clone element (#28) * Switch to using clone element * Exclude children from interface * Add multiref * Bump rollup and add rollup-ts * Use ref from child component for click away * Remove usued package * alpha 6 * Restor peer dependencies * Add proper types and increase coverage * Ensure the ref is clickable * Update workflow name * Remove release file * fix: publish * perf: New release 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone elements and attach the click away listener to the children as opposed to creating a new component.