Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close branches, Open folders #6

Closed
ooade opened this issue Oct 1, 2018 · 9 comments
Closed

Close branches, Open folders #6

ooade opened this issue Oct 1, 2018 · 9 comments

Comments

@ooade
Copy link
Owner

ooade commented Oct 1, 2018

The branches thing might be a little bit costly and a slower approach to move around this project. I suggest we change to a folder view since it's easy to use multiple stores in Vue(x) projects.

Anyone willing to take this?
Folder Structure would be like this:

  • starter-files (contains everything in the master branch except src and store, the rest needs to be merged)
  • auth (contains everything in the auth branch except src and store)
  • and so on...
@ooade
Copy link
Owner Author

ooade commented Oct 1, 2018

Do you mind working on this @krns?

@ooade
Copy link
Owner Author

ooade commented Oct 1, 2018

Besides, if you're good with testing Vue Components, I might need some help with it over at the pimg - superb lazyloader repo

@fgriberi
Copy link

fgriberi commented Oct 1, 2018

Hi @ooade, I'm available to contribute with this issue, so the idea here is to move the stale branches (auth, counter, simple-todo, shopping-cart and firestore) into folders on master?

@ooade
Copy link
Owner Author

ooade commented Oct 2, 2018

Yeah @fgriberi 👍

@fgriberi
Copy link

fgriberi commented Oct 2, 2018

@ooade cool! I'm going to work in this issue

@ooade
Copy link
Owner Author

ooade commented Oct 2, 2018

Okay @fgriberi. That's good to know 💪

@fgriberi
Copy link

fgriberi commented Oct 2, 2018

@ooade I've already created a PR for this issue, just take a look

@ooade
Copy link
Owner Author

ooade commented Oct 3, 2018

Okay. I will

@fgriberi
Copy link

fgriberi commented Oct 3, 2018

@ooade Thx... It's possible to assign me the issue and close it?

@ooade ooade closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants