-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GHATD-X] Implement separation between the framework and full-stack components #2
Draft
ooaklee
wants to merge
7
commits into
main
Choose a base branch
from
ghatd-x-separation-between-the-framework-and-full-stack-components
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[GHATD-X] Implement separation between the framework and full-stack components #2
ooaklee
wants to merge
7
commits into
main
from
ghatd-x-separation-between-the-framework-and-full-stack-components
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Begin shaping out the cli, which will be used to create, manage and set up ghat(d) applications - the first focus will be the 'new' command - Updated existing server: - stripped out previously included API + web services - Added markings for substitution - Updated import paths - Split out some packages to be "ghat(d) official" - Packages that can be shared across ghat(d) details/ apps now moved to external dir - Added ADR + first ADR to explain the split - Added packages that will be included in the base repo in the internal folder (excluding internal/cli) - Updated testing folder to have a split between what will be used for cli etc, vs the base directory - Updated README to account for changes (introduction of detail) - Updated 'internal/webapp' to 'internal/web'
- Initial steps added to `new` command - Updates to error key, Detail config, and `go.mod` tags - "New" command logic for restructuring and merging details into a new app - Refactor toolbox can search/replace strings, *DetailEmbeds removed - Output added to the available `new` flag, "web" suffix added to embeddedContentFilePathPrefix - Fetch new app's core from GitHub; clean-up triggered on failure - Template and ADR added for converting the project to Detail and modularized set-up - Access manager, API token manager, audit logger, auth, emailer, ephemeral data storage, middleware, OAuth manager, user manager, and user management service added to help users get started - Repository methods added for DB writing services; common headers, static User Roles, and toolbox helper functions added - Access manager handler now extendable; method added for cleaning all tokens except current; auth service updated - Paginator shapes pagination response; title case added to toolbox; helper functions added to repository package to calculate pagination skip and limit - A method was added to get total users based on parameters.
- Updated user model to remove slice - Stop AMS updating slice when adding a new user token - Updated logic when deleting token to use apiToken service solely - Remove the repository method that handled deleting from token slice
- Added Human readable fields to ApiToken - Added method for calculating the human readable time difference - Moved time format (RFC3339NanoUTC) to common folder - Updated referencs for time format
- bug fix: Made sure magic tokens are deleted on first use - small refactor - When processing the refresh token, check for an access token - Added check for refresh when processing a user log-out - Added combined UUid to the toolbox - Added method to handle Remove & Access removals, respectively - When signing out, now check to see if the redirect response should be returned - Added const for representing platform header
- Added endpoint and logic to allow user to clear their other sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Related Link(s):
N/A
Will need to utilise the following components (
Details
):What has been done:
internal/webapp
tointernal/web
How to test: