Add a scrollbar to notebook/default textboxes, improve chat scrollbar style #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the main Textbox in Notebook Mode show a scrollbar
|
I have moved the javascript into Is it possible to get a consistent appearance for the scrollbars? Mine looks uglier than yours:
|
oobabooga
changed the title
|
I have added a CSS style for the scrollbar. It can probably be made prettier, but that should do it for now. Thanks! |
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the "Raw" Textbox in Notebook Mode show a vertical scrollbar when there is enough text. This is a workaround for a Gradio issue (see: gradio-app/gradio#4050, gradio-app/gradio#4044). Tested working on Edge and Chrome.
This is achieved by injecting a simple JavaScript function while creating the Gradio interface and then firing it as soon as the document loads. The same effect could be applied to any UI element by calling
enableScrollBarOnElementlike I do on the raw textbox here.I tried various CSS modifications but Gradio's
scroll-hideultimately prevents CSS fixes from working. The scrollbar seems finicky and would not display even if I overrode Gradio's CSS with!important. So JavaScript was necessary.Before:
After:
