Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid importing torch in one-click-installer #4064

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

jllllll
Copy link
Contributor

@jllllll jllllll commented Sep 25, 2023

Checklist:


__version__ in torch is derived from version.py. So, to avoid issues with Windows not uninstalling torch dependencies, this will just read that value directly from version.py if possible.


Fixes: #4063

@oobabooga
Copy link
Owner

That's pretty damn impressive. Well done!

@oobabooga oobabooga merged commit c0fca23 into oobabooga:main Sep 25, 2023
@jllllll jllllll deleted the one-click-torch branch September 25, 2023 01:20
@BenevolenceMessiah
Copy link

Wow. You fixed that really quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows One-Click Installer Seemingly Broken (may be related to previously mentioned module error)
3 participants