Make new browser reloads recognize current model (fixes #4843) #4865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a long-standing UI bug #4843 the simplest way possible.
Essentially instead of just giving the model name as the value, which then gets cached and not replaced...ever, we give a
Callable
that returns the current model name so each time it generates the UI for a 'new' browser session, it updates the model name to be whatever's current.Before this change, the displayed name would always be the default after a reload or when hit by another browser. I ran into it most often when switching between iPhone and desktop. With this change it shows the latest model loaded. And yes, the pull request is a hundred times longer than the change, but it took me hours to get here. 馃ぃ
Checklist: