M057: Integrates preloading of External DataSources as meta data resouces for use in Geonetwork #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmeisinger @jamie-cyber1 please review |
|
Can you rebase on ooici master branch to remove the merge commits? |
add bootstrap process for m057 geonetwork services add data source check added data sources to category list add test class replace with master sheet add additional test update eoi_registration to include harvester request fix create harvester registration add missing & update and add tests for geonetwork harvester resources update table loader to verify parameter list, requires removing prints before pull request is made update tests for geonetwork services update source removing print statements remove print statement update tests, allowing for removal of harvesters added during preload.
|
@jamie-cyber1 i rebased and fix the broken test, please review |
| return False | ||
|
|
||
|
|
||
| def _register_data_source(self, event, *args, **kwargs): |
There was a problem hiding this comment.
You should place a general try-except Exception block around the main threads. These are long running and you cannot afford to lose them to some random exception
|
Looks good |
|
@jamie-cyber1 can we merge? i will address Michael's comment in a subsequent pull request |
jamie-cyber1
pushed a commit
that referenced
this pull request
May 29, 2014
M057: Integrates preloading of External DataSources as meta data resouces for use in Geonetwork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds source and tests for eoi geonetwork meta data ingestion via preload datasources