Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose App localizationsDelegates property #11

Closed
DavidRG13 opened this issue Jun 21, 2020 · 5 comments
Closed

Expose App localizationsDelegates property #11

DavidRG13 opened this issue Jun 21, 2020 · 5 comments

Comments

@DavidRG13
Copy link
Contributor

Would it make any sense to expose this App localizationsDelegates in Storybook?

We are using FlutterI18n and have some widgets configured to use translations, making it impossible for us to use storybook for those widgets.

Great project!
@ookami-kb
Copy link
Owner

Thanks!

Yeah, I guess it makes total sense.

@DavidRG13
Copy link
Contributor Author

Cool, do you want me to raise a PR?

@ookami-kb
Copy link
Owner

Yep, that would be great 👍

DavidRG13 added a commit to DavidRG13/storybook_flutter that referenced this issue Jun 22, 2020
@DavidRG13
ookami-kb#11 Adds support to override App localization delegates
553b16a
@DavidRG13 DavidRG13 mentioned this issue Jun 22, 2020
Merged
@DavidRG13
Copy link
Contributor Author

@ookami-kb , thanks for checking and merging the PR!

When could we expect a new release? No rush, just to be aware ;)

@ookami-kb
Copy link
Owner

Thank you for the PR!

Just released :)

@afl-dev afl-dev mentioned this issue Jan 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ookami-kb @DavidRG13