NullReferenceException when showing TaskDialog without buttons

[mgpreston]

If you attempt to call ShowDialog on a TaskDialog that you haven't added any buttons to, the call to ShowDialog will throw a NullReferenceException.

Could this be improved to throw a more meaningful exception - or perhaps add a default button to it?

Example:

var dialog = new Ookii.Dialogs.Wpf.TaskDialog {
	Content = "Message",
	MainInstruction = "Instruction"
};

dialog.ShowDialog(); // NullReferenceException here. dialog is not null.

Thank you!

[augustoproiete]

Thanks for reporting @mgpreston. I fixed the NullReferenceException so that a more meaningful exception is thrown, but showing a default button might be a better experience.

What do you think the button should be? OK? Close? Cancel? Something else?

[mgpreston]

That's great, thanks!

I would be tempted to go for OK as the default button, but I'd consider any of them to be fine.

[augustoproiete]

Tracking adding the default button via #55

Closing this one as fixed by 5582dcb

[augustoproiete]

🎉 This issue has been resolved in Ookii.Dialogs.Wpf v4.0.0

The release is available on:

• 🚀 GitHub Release
• 📦 NuGet Package