Modal ProgressDialog: restore focus to owner #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grazie @FedeMiorelli looks good. I'll get this merged over the weekend. |
When using a modal ProgressDialog (with ShowDialog()) the focus does not return to the owner window. Additionally, when running under Wine emulation on Linux, the window becomes unresponsive as it remains in disabled state. This patch restores the behavior by calling user32.dll EnableWindow on the owner handle
augustoproiete
force-pushed
the
master
branch
from
f7b03fd
to
73430f7
Compare
|
@FedeMiorelli your changes have been merged, thanks for your contribution 👍 |
|
@augustoproiete thank you! |
|
Hi @augustoproiete is a 3.2.0 release planned including this PR? Thanks |
|
@FedeMiorelli Yes, this is what's included n 3.2.0: https://github.com/ookii-dialogs/ookii-dialogs-wpf/milestone/8 There's a couple of issues open there that I'd like to close before shipping 3.2.0 - let me know if you're blocked and I can easily ship a pre-release to NuGet with the latest commits in |
|
Hi @augustoproiete thanks for the kind offer, no rush on my end.. Cheers |
|
🎉 This issue has been resolved in Ookii.Dialogs.Wpf v4.0.0 The release is available on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a modal ProgressDialog (with ShowDialog()) the focus does not return to the owner window.
Additionally, when running under Wine emulation on Linux, the window becomes unresponsive as it remains in disabled state.
This patch restores the behavior by calling user32.dll EnableWindow on the owner handle.
Also solves issues like this:
https://stackoverflow.com/questions/21920645/ookii-dialogs-progressdialog-in-modal-style-doesnt-focus-owner-window-after-com