Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pool): ignore unavailable nodes #45

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix(pool): ignore unavailable nodes #45

merged 1 commit into from
Feb 16, 2023

Conversation

ooliver1
Copy link
Owner

Summary

This PR alters NodePool to not store unavailable nodes.

14.02.2023 13:19:06 | WARNING | Unable to use best node, player not connected, finding random node.
14.02.2023 13:19:06 | ERROR | No nodes found for the region, defaulting to all nodes.

Checklist

  • If code changes were made then they have been tested.
  • I have run task lint to format code and my changes.
  • I have run task pyright and fixed the relevant issues.

@ooliver1 ooliver1 added t: bug Type: bug - something isn't working p: high Priority: high - should be worked on as soon as reasonable labels Feb 16, 2023
@ooliver1 ooliver1 enabled auto-merge (squash) February 16, 2023 16:17
@ooliver1 ooliver1 merged commit f2d6b22 into master Feb 16, 2023
@ooliver1 ooliver1 deleted the fix/ignore-unavailable-nodes branch February 16, 2023 16:19
This was referenced Feb 16, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p: high Priority: high - should be worked on as soon as reasonable t: bug Type: bug - something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ooliver1