Allow user to type in FPS and audio bitrate value instrad of using Spinner #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Widget for: * Setting custom fps * Change from Spinner to EditText for AudioBitrate
if no audio, default set to 128
|
Anyone here know how to fix build? i have searched and tried to fix it but can't |
oong819
added
enhancement
|
nvm, i just found out that i should read the bottom of the log instead of the first exception |
a(b(c););
(Last commit screwed up XD)
again...
|
Current problem: somehow the custom FPS input container did not display when Custom are choosed Currently stuck, can't find out why, need help |
(I dont have a PC)
it's a tiny layout XML change
|
everthing are fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio bitrate now use EditText instead of Spinner, allow user to type in value instead of choose a pre-defined value
FPS Spinner now have a "custom" option, choosing it display a EditText for user to type in
(Audio bitrate are checked to be valid int similar to video bitrate checking, custom FPS are checked to be valid float)
I tried to match the code style of brarcher to avoid code style inconsistence
TODO: translate new 2 invalid value message string