This repository has been archived by the owner on May 5, 2023. It is now read-only.
Reprocessing and switch to Clickhouse #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedericoCeratto
force-pushed
the
reprocessing
branch
from
b1ab091
to
e186893
Compare
hellais
reviewed
Aug 4, 2022
newapi/ooniapi/measurements.py
Outdated
| resp.mimetype = "application/json" | ||
| resp.cache_control.max_age = 3600 | ||
| if download: | ||
| set_dload(resp, "measurement.json") |
There was a problem hiding this comment.
Can we put the measurement_uid inside of the filename here?
There was a problem hiding this comment.
Can you integrate the suggested change I made below to the filename format?
hellais
reviewed
Aug 4, 2022
hellais
reviewed
Aug 4, 2022
Co-authored-by: Arturo Filastò <arturo@filasto.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to Clickhouse, support configurable collector ID, multiple bugfixes, cleanup and type checking.