Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastapi based API #45

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Fastapi based API #45

wants to merge 21 commits into from

Conversation

hellais
Copy link
Member

@hellais hellais commented Nov 21, 2023

This implements: #35

This branch is based on top of #44. That one should be merged before this one is ready to be landed in master.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: Patch coverage is 65.34653% with 140 lines in your changes are missing coverage. Please review.

Project coverage is 81.40%. Comparing base (b3f354d) to head (be5a1c5).
Report is 2 commits behind head on main.

Files Patch % Lines
oonidata/fastapi/routers/observations.py 0.00% 80 Missing ⚠️
oonidata/fastapi/routers/aggregation.py 73.10% 32 Missing ⚠️
oonidata/fastapi/routers/measurements.py 80.00% 27 Missing ⚠️
oonidata/fastapi/dependencies.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   82.43%   81.40%   -1.03%     
==========================================
  Files          78       86       +8     
  Lines        6307     6711     +404     
==========================================
+ Hits         5199     5463     +264     
- Misses       1108     1248     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hellais
Copy link
Member Author

hellais commented Mar 6, 2024

I cherry picked 2d9e6d5 directly into master so this is only changes related to fastapi.

We should probably move this branch into ooni/backend in the oonidataaapi package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant