Module refactor #14
Merged
Module refactor #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to make use of the moved {} syntax to ensure we can apply
without recreating all the resource
These moved blocks can then be removed once the changes have been
applied.
Terraform Run Output 🤖Format and Style 🖌
|
| Pusher | @hellais |
| Action | pull_request |
| Environment | dev |
| Workflow | .github/workflows/check_terraform.yml |
| Last updated | Thu, 14 Mar 2024 07:43:23 GMT |
Ansible Run Output 🤖Ansible Playbook Recap 🔍Ansible playbook output 📖
|
| Pusher | @hellais |
| Action | pull_request |
| Working Directory | |
| Workflow | .github/workflows/check_ansible.yml |
| Last updated | Thu, 14 Mar 2024 07:43:59 GMT |
Please enter the commit message for your changes. Lines starting
Please enter the commit message for your changes. Lines starting
hellais
force-pushed
the
module-refactor
branch
from
f10162b
to
99d9455
Compare
This adds a new IAM user: ooni_dev_user which shall be used as the github user to run terraform apply. This IAM user has been given minimal ReadOnly permissions to resources which allow it to successfully run `terraform plan` Closes: #16 --------- Co-authored-by: Arturo Filastò <arturo@filasto.net>
DecFox
reviewed
Mar 14, 2024
| "ecr:*", | ||
| "ecr-public:*", | ||
| "rds:*", | ||
| "vpc:*", |
There was a problem hiding this comment.
Suggested change
| "vpc:*", | |
| "vpc-lattice:*", |
I don't think vpc is a valid service name for AWS. There is also a warning on the console for the same. I think we should be using vpc-lattice instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to refactor the various resource groups into modules to make it easier to develop the test environment.
See: #6