feat: add probe-engine to sidebar #5
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
astro.config.mjs
Outdated
| { | ||
| label: "Probe Engine", | ||
| autogenerate: { directory: "probe-engine" }, | ||
| } |
There was a problem hiding this comment.
Let's put it above Legacy Backend. Otherwise LGTM
|
I had to apply a few fixes to the master branch of probe-cli to get it to write the docs properly, but it's now good to go. It's still failing to build due to it missing the support for the languages. I will install this plugin that should fix it: https://expressive-code.com/installation/ |
|
Syntax highlighting is not working so well, but I think it's good enough. Also some pages look empty or incomplete. You might want to look into that before we merge it. |
|
It runs locally, but it's failing on vercel. Probably worth debugging tomorrow. @DecFox |
* origin/main: auto: update backend docs to f04f8558
error was: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (npm/cli#4828). Please try `npm i` again after removing both package-lock.json and node_modules directory
|
This looks great, the only nitpick is that these two side-bars aren't lighting up. It's probably and issue in how the The side-bars not working are:
I suggest we merge this and document this as future work as it's still fully functional |
There was a problem hiding this comment.
Let's land it and document as an issue what I said in: #5 (comment)
|
Thanks! The bug has been documented here: #6. I am going to go ahead and merge. |
This diff adds
probe-engineto the sidebar. We added the docs to docs.ooni.org here: ooni/probe-cli#1634