New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename components to use CamelCase convention #336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could only find time to go through half of the files changed. I have some feedback for now, I will get to the rest later, maybe after the requested changes are made.
test-info
,withIntl
,utils
- These files do not necessarily export components. So these can remain the way they are.withIntl
is a HoC definition and usually starts with lowercase.AsnSelector
,UrlChart
- This is not a big deal, but it should be consistent. In some places it isASNSelector
in others you usedAsnSelector
. Since they are acronyms, I preferASNSelector
andURLChart
.
box.js
- This doesn't export aBox
component, instead exports a couple of variants. So maybe rename it toboxes.js
(yes, lowercase).
flag
- This hasn't been renamed yet, but you already import from../Flag
in one of the files. Same withheader
andfooter
.
I understand this is a lot of tedious work and it is much appreciated. Thank you ❤️
I am guessing renaming |
There was a problem in my git configuration
Well, there is a problem in my git configuration - don't merge this yet |
When you think it is ready for review just use the "re-request" button(last step) to notify me. |
I discovered the problem. I thought it was my Git configuration, but turns out that I was editing on a case-insensitive file system. Sorry about the mess - everything is properly renamed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lucaspontoexe for the PR. I added a few fixes because I felt some files need not be renamed, and a few imports needed to use new filenames. This is ready for merge.
UpperCamelCase, actually.
(Closes #201)