Refactored measurement page using refactored API #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses mock response for upcoming measurement_meta API endpoint
sarathms
force-pushed
the
use-get-measurement
branch
from
8d0f1c7
to
48806cb
Compare
|
@sarathms let's take at look at this together later today? 🙏 |
bassosimone
changed the title
bassosimone
reviewed
Sep 17, 2020
| } | ||
|
|
||
| Measurement.propTypes = { | ||
| measurement: PropTypes.object.isRequired, | ||
| measurement: PropTypes.object, |
There was a problem hiding this comment.
@sarathms please make sure we list all the props here
bassosimone
reviewed
Sep 18, 2020
bassosimone
added a commit
to ooni/e2etesting
that referenced
this pull request
Sep 22, 2020
We're aiming for writing a full end to end experiment where the code performs measurements and then fetches them back from API. However, the API code currently does not store measurements submitted by us using ams-pg.ooni.org, so we cannot go that far. Yet, let us have support for this functionality, which has been tested by adapting ooni/explorer#486. Also, for now just write basic smoke testing. The diff itself details a plan for integrating this code into probe-engine. When we'll do that we'll most likely want to write more testing code. This work is part of ooni/backend#446.
bassosimone
added a commit
to ooni/e2etesting
that referenced
this pull request
Sep 22, 2020
We're aiming for writing a full end to end experiment where the code performs measurements and then fetches them back from API. However, the API code currently does not store measurements submitted by us using ams-pg.ooni.org, so we cannot go that far. Yet, let us have support for this functionality, which has been tested by adapting ooni/explorer#486. Also, for now just write basic smoke testing. The diff itself details a plan for integrating this code into probe-engine. When we'll do that we'll most likely want to write more testing code. This work is part of ooni/backend#446.
bassosimone
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
I think we should merge now and without reverting anything. Because we only deploy releases, our master branch represents a development snapshot towards the goal we have in mind for the next release. Therefore, I believe it's in our best interest to bring this good set of changes to master such that we can immediately start using them along with others.
🐳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #489
Uses the new
/api/v1/measurement_metaAPI to fetch measurement data.Revert 8d0f1c7 before mergingWe decided to continue to use theams-pg.ooni.orghostname for now.