montreal2017: review and add additional notes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
commented
Oct 13, 2017
| (We did not reach consensus on whether a censorship event includes also the network inside the country.) |
There was a problem hiding this comment.
I remember that we did not agree on that.
bassosimone
commented
Oct 13, 2017
| @@ -12,13 +12,13 @@ Sanitization procedure -- > Raw data is stored forever, but we sanitize it befor | |||
|
|
|||
| There are some sanitization checks that don't pass due to formatting reasons. | |||
|
|
|||
| Eventually the data ends up in postgress database. This is not the best database, but it's good enough. As the raw data storage increases, we will need to consider an alternative. | |||
| Eventually the metadata ends up in postgress database. This is not the best database, but it's good enough. As the raw data storage increases, we will need to consider an alternative. | |||
There was a problem hiding this comment.
My understanding is that the new pipeline's database doesn't store data.
There was a problem hiding this comment.
Depends on the definition of data I guess. Some data does end up in the DB, I am ok with either though.
bassosimone
commented
Oct 13, 2017
|
|
||
| How to run this: | ||
|
|
||
| The code is basically stored in a docker image, so you can use whatever software you like. Airflow is a bunch of python libraries with their own version and you don't want to have conflicts and resolve them. So you have to build a docker image to run the software. | ||
|
|
||
| How do you add the docker image to a chain (like described below)? You upload the docker image to docker hub, and then make the pipeline run this image through operations with elevated privileges (Airflow does this through a wraper script, run with sudo). At the end of these basic checks and setups, docker runs something and that's it. | ||
| How do you add the docker image to a chain (like described below)? You upload the docker image to docker hub, and then make the pipeline run this image through operations with elevated privileges (we do this through a wrapper script, run with sudo). At the end of these basic checks and setups, docker runs something and that's it. |
There was a problem hiding this comment.
My understanding is that @darkk wrote a custom wrapper for sudo.
hellais
reviewed
Oct 20, 2017
| @@ -1,6 +1,6 @@ | |||
| # Mobile apps | |||
|
|
|||
| IMPORTANT: Automated testing (possibly implemented in node). | |||
| IMPORTANT: continuous-integration testing (possibly implemented in node). | |||
There was a problem hiding this comment.
I would call this end-to-end testing rather than CI.
|
minor nit-pick. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly hotfixes. I've added comments in places where I changed the meaning of sentences.