refactor: introduce tun #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
reviewed
Jan 19, 2024
Co-authored-by: Simone Basso <bassosimone@gmail.com>
bassosimone
reviewed
Jan 19, 2024
bassosimone
approved these changes
Jan 22, 2024
ainghazal
added a commit
that referenced
this pull request
Jan 24, 2024
This is a follow-up to the ongoing architectural refactor after the last merged layer (#54). Here we add documentation to the layered approach. Additionally, we change the `OnWorkerDone()` call so that the worker's name is passed in the call and logging responsibility for the done event belongs to the `workers.Manager`. Reference issue: #47 --------- Co-authored-by: Simone Basso <bassosimone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the seventh (and in a sense, last) commit in the series of incremental refactoring of the current minivpn tree. With this package we have all the needed layers to start reasoning about the complete architecture.
TUN uses a similar strategy to the TLSBio in the tlssession package: it uses channels to communicate with the layer below (the data channel), and it buffers reads.
Reference issue: #47