Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pass logger to tls #59

Merged
merged 1 commit into from
Jan 31, 2024
Merged

refactor: pass logger to tls #59

merged 1 commit into from
Jan 31, 2024

Conversation

ainghazal
Copy link
Collaborator

Checklist

  • I have read the contribution guidelines
  • Iff you changed code related to services, or inter-service communication, make sure you update the diagrams in ARCHITECTURE.md.
  • Reference issue for this pull request: NA

Description

Pass a logger to the TLSBio instead of using a global logger.

bassosimone
bassosimone approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@ainghazal ainghazal merged commit 2e2be95 into ooni:main Jan 31, 2024
@ainghazal ainghazal deleted the feat/pass-logger branch January 31, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ainghazal @bassosimone