Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: reliable workers tests for reordering and acks #60

Merged
merged 81 commits into from
Feb 7, 2024
Merged

tests: reliable workers tests for reordering and acks #60

merged 81 commits into from
Feb 7, 2024

Conversation

ainghazal
Copy link
Collaborator

@ainghazal ainghazal commented Feb 2, 2024 •
edited
Loading

Checklist

  • I have read the contribution guidelines
  • Iff you changed code related to services, or inter-service communication, make sure you update the diagrams in ARCHITECTURE.md: NA
  • Reference issue for this pull request: NA

Description

Tests for down and up workers in reliable service, covering reordering towards the upper layer and checking that any incoming packet is eventually ACKed.

This PR also includes some needed test utilities that can be reused to exercise different parts of the system.

@ainghazal
implementation of reliable transport
91057af
@ainghazal
rename & reordering
aebf87e
@ainghazal
wip
b420eb1
@ainghazal
remove command, separate pr
add18bd
@ainghazal
add command to get handshake logs
2c9761f
@ainghazal
remove unused code
51e2d34
@ainghazal
add sender logging
c3cb64d
@ainghazal
add precision time logging in the text handler
c85b9f3
@ainghazal
clearer logging
ba650b8
@ainghazal
unify packet logging
0525989
@ainghazal
checkpoint: improve logging, hack client hello ack to get moving
9e5b744
@ainghazal
checkpoint
f34af5c
@ainghazal
checkpoint
ff1ec51
@ainghazal
x
06d6c37
@ainghazal
testing
bfd4380
@ainghazal
pass option to do just the handshake and no routes
44c6f9b
@ainghazal
defend if data before keys
0e074d1
@ainghazal
improve comment
2c6c941
@ainghazal
comment on newHardResetPacket
b512ad9
@ainghazal
comments
690762e
@ainghazal
add elapsed time for benchmarking
675fd8f
@ainghazal
log
5b4d2eb
@ainghazal
add doc.go
8c5816c
@ainghazal
x
0c37284
@ainghazal
remove unused code
2fb6a3c
@ainghazal
move comment location
80adb95
@ainghazal
x
ba94049
@ainghazal
remove commented code
c941f02
@ainghazal
add link in docs
1bc2361
@ainghazal
rename in test
20f89e2
@ainghazal ainghazal changed the title wip: tests for reliable service tests: reliable workers tests for reordering and acks Feb 2, 2024
@ainghazal ainghazal self-assigned this Feb 2, 2024
@ainghazal ainghazal mentioned this pull request Feb 6, 2024
Merged
3 tasks
bassosimone
bassosimone approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

LGTM when all the comments have been responded to or addresses. Need to rediscuss if some comment causes us to make significant changes.

internal/model/packet.go Outdated Show resolved Hide resolved
internal/model/packet.go Outdated Show resolved Hide resolved
internal/reliabletransport/common_test.go Outdated Show resolved Hide resolved
internal/reliabletransport/receiver.go Outdated Show resolved Hide resolved
internal/reliabletransport/receiver.go Show resolved Hide resolved
internal/reliabletransport/sender.go Show resolved Hide resolved
internal/vpntest/packetio.go Outdated Show resolved Hide resolved
internal/vpntest/packetio.go Show resolved Hide resolved
internal/vpntest/packetio.go Show resolved Hide resolved
internal/vpntest/packetio.go Outdated Show resolved Hide resolved
ainghazal and others added 3 commits February 7, 2024 16:45
@ainghazal @bassosimone
Update internal/model/packet.go
56ab133 
Co-authored-by: Simone Basso <bassosimone@gmail.com>
@ainghazal @bassosimone
Update internal/vpntest/packetio.go
20deba9 
Co-authored-by: Simone Basso <bassosimone@gmail.com>
@ainghazal
address comments from code review
8a042ba
@ainghazal ainghazal merged commit a3610f7 into ooni:main Feb 7, 2024
8 checks passed
@ainghazal ainghazal deleted the reliable-service-tests branch February 7, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees

@ainghazal ainghazal

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ainghazal @bassosimone