BREAKING CHANGE: unify UNetStack and CA's CertificationAuthority behavior #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vior The UNetStack and CA structures have similar functionality exposed through a different interface, which causes us to create an interface and a wrapper for the code in probe-cli. I noticed about this when I was trying to integrate new netem changes, and it occurred to me we can just make the interfaces uniform here and avoid wrapping in probe-cli. Also part of ooni/probe#2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UNetStack and CA structures have similar functionality exposed through a different interface, which causes us to create an interface and a wrapper for the code in probe-cli.
I noticed about this when I was trying to integrate new netem changes, and it occurred to me we can just make the interfaces uniform here and avoid doing some additional work in probe-cli.
Note: this is a breaking change because
(*Ca).CACertwas a field and now is a method.Also part of ooni/probe#2531