Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of Risks, FAQ and Glossary documents into Farsi #1359

Merged
merged 9 commits into from
Mar 22, 2023
Merged

Translation of Risks, FAQ and Glossary documents into Farsi #1359

merged 9 commits into from
Mar 22, 2023

Conversation

sloncocs
Copy link
Contributor

  • make sure that outreach happens
  • when merging, double check that the publication date is today

@sloncocs sloncocs self-assigned this Mar 17, 2023
@sloncocs sloncocs requested a review from agrabeli March 17, 2023 12:33
@sloncocs sloncocs added documentation Improvements or additions to documentation translation labels Mar 17, 2023
agrabeli
agrabeli approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@agrabeli agrabeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Miaan Group for the translations, and thank you @sloncocs <3

According to @hellais the FAQ ToC should work upon merging the PR and publishing it.

Generally though, the PR seems ready for merging.

@agrabeli agrabeli merged commit 831b699 into ooni:master Mar 22, 2023
@sloncocs sloncocs deleted the translations-risks-faq-glossary-FA branch April 3, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrabeli agrabeli agrabeli approved these changes

Assignees

@sloncocs sloncocs

Labels
documentation Improvements or additions to documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloncocs @agrabeli