Skip to content

Commit

Permalink
x
Browse files Browse the repository at this point in the history
  • Loading branch information
bassosimone committed Jun 19, 2024
1 parent 7a82390 commit 562d0a7
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions docs/design/dd-008-richer-input.md
Original file line number Diff line number Diff line change
Expand Up @@ -352,12 +352,12 @@ the changes roughly look like this:
}
```

Note how we MUST gracefully cast to `*target` (as we did in [probe-cli#XXX](
XXX)) because richer input could potentially come from ~any source, including
the mobile app. While richer input is anything that fullfills the
`model.ExperimentTarget` interface, mobile apps could, for example,
construct a Java class implementing such an interface but we wouldn't
be able to cast such an interface to the `*target` type. Therefore,
Note how we MUST gracefully cast to `*target` (as we did in [probe-cli#1623](
https://github.com/ooni/probe-cli/pull/1623)) because richer input could
potentially come from ~any source, including the mobile app. While richer input
is anything that fullfills the `model.ExperimentTarget` interface, mobile apps
could, for example, construct a Java class implementing such an interface but we
wouldn't be able to cast such an interface to the `*target` type. Therefore,
unconditionally casting could lead to crashes when integrating new code
and generally makes for a less robust codebase.

Expand Down

0 comments on commit 562d0a7

Please sign in to comment.