Skip to content

Commit

Permalink
[forwardport] fix: use correct Xcode and mingw version (#1158)
Browse files Browse the repository at this point in the history
This diff forward ports 8a85b63 to the
master development branch.

We have updated the runners, so the versions have changed as well.

See ooni/probe#2417
  • Loading branch information
bassosimone committed Jun 8, 2023
1 parent f3508a2 commit 9ecdb50
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ios.yml
Expand Up @@ -35,7 +35,7 @@ jobs:
PSIPHON_CONFIG_KEY: ${{ secrets.PSIPHON_CONFIG_KEY }}
PSIPHON_CONFIG_JSON_AGE_BASE64: ${{ secrets.PSIPHON_CONFIG_JSON_AGE_BASE64 }}
- run: make EXPECTED_XCODE_VERSION=13.2.1 MOBILE/ios
- run: make EXPECTED_XCODE_VERSION=14.2 MOBILE/ios

- uses: actions/upload-artifact@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows.yml
Expand Up @@ -38,7 +38,7 @@ jobs:
PSIPHON_CONFIG_KEY: ${{ secrets.PSIPHON_CONFIG_KEY }}
PSIPHON_CONFIG_JSON_AGE_BASE64: ${{ secrets.PSIPHON_CONFIG_JSON_AGE_BASE64 }}
- run: make EXPECTED_MINGW_W64_VERSION="9.3-win32" CLI/windows
- run: make EXPECTED_MINGW_W64_VERSION="10-win32" CLI/windows

- uses: actions/upload-artifact@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/ghgen/ios.go
Expand Up @@ -24,7 +24,7 @@ func buildAndPublishMobileIOS(w io.Writer, job *Job) {
newStepCheckout(w)
newStepSetupGo(w, "ios")
newStepSetupPsiphon(w)
newStepMake(w, "EXPECTED_XCODE_VERSION=13.2.1 MOBILE/ios")
newStepMake(w, "EXPECTED_XCODE_VERSION=14.2 MOBILE/ios")
newStepUploadArtifacts(w, artifacts)

newJob(w, publishJob, runsOnUbuntu, buildJob, contentsWritePermissions)
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/ghgen/windows.go
Expand Up @@ -28,7 +28,7 @@ func buildAndPublishCLIWindows(w io.Writer, job *Job) {
newStepSetupGo(w, "windows")
newStepInstallMingwW64(w)
newStepSetupPsiphon(w)
newStepMake(w, "EXPECTED_MINGW_W64_VERSION=\"9.3-win32\" CLI/windows")
newStepMake(w, "EXPECTED_MINGW_W64_VERSION=\"10-win32\" CLI/windows")

newStepUploadArtifacts(w, artifacts)

Expand Down

0 comments on commit 9ecdb50

Please sign in to comment.