refactor: prepare for renaming all experiments (#1032)

This diff prepares the ground for renaming all experiments. We will move each experiment from internal/engine/experiment/NAME to internal/experiment/NAME. Before we can do that, we need to rename the already existing internal/experiment/webconnectivity to become webconnectivitylte. Otherwise, we will have a naming conflict since there is also internal/engine/experiment/webconnectivity.

See ooni/probe#2115

internal/experiment/webconnectivity/analysiscore.go → internal/experiment/webconnectivitylte/analysiscore.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 import (
 	"fmt"

internal/experiment/webconnectivity/analysisdns.go → internal/experiment/webconnectivitylte/analysisdns.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // DNS analysis

internal/experiment/webconnectivity/analysishttpcore.go → internal/experiment/webconnectivitylte/analysishttpcore.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // HTTP core analysis

internal/experiment/webconnectivity/analysishttpdiff.go → internal/experiment/webconnectivitylte/analysishttpdiff.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // HTTP diff analysis

internal/experiment/webconnectivity/analysistcpip.go → internal/experiment/webconnectivitylte/analysistcpip.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // TCP/IP analysis

internal/experiment/webconnectivity/analysistls.go → internal/experiment/webconnectivitylte/analysistls.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // TLS analysis

internal/experiment/webconnectivity/cleartextflow.go → internal/experiment/webconnectivitylte/cleartextflow.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // CleartextFlow

internal/experiment/webconnectivity/config.go → internal/experiment/webconnectivitylte/config.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // Config

internal/experiment/webconnectivity/control.go → internal/experiment/webconnectivitylte/control.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 import (
 	"context"

internal/experiment/webconnectivity/dnscache.go → internal/experiment/webconnectivitylte/dnscache.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 import "sync"
 

internal/experiment/webconnectivity/dnsresolvers.go → internal/experiment/webconnectivitylte/dnsresolvers.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // DNSResolvers

internal/experiment/webconnectivity/dnswhoami.go → internal/experiment/webconnectivitylte/dnswhoami.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 import (
 	"context"

internal/experiment/webconnectivity/doc.go → internal/experiment/webconnectivitylte/doc.go

@@ -1,7 +1,7 @@
-// Package webconnectivity implements the web_connectivity experiment.
+// Package webconnectivitylte implements the web_connectivity experiment.
 //
 // Spec: https://github.com/ooni/spec/blob/master/nettests/ts-017-web-connectivity.md.
 //
 // This implementation, in particular, contains extensions over the original model,
 // which we document at https://github.com/ooni/probe/issues/2237.
-package webconnectivity
+package webconnectivitylte

internal/experiment/webconnectivity/inputparser.go → internal/experiment/webconnectivitylte/inputparser.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // Input parsing

internal/experiment/webconnectivity/iox.go → internal/experiment/webconnectivitylte/iox.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // Extensions to incrementally stream-reading a response body.

internal/experiment/webconnectivity/measurer.go → internal/experiment/webconnectivitylte/measurer.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // Measurer

internal/experiment/webconnectivity/priority.go → internal/experiment/webconnectivitylte/priority.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // Determine which connection(s) are allowed to fetch the webpage

internal/experiment/webconnectivity/redirects.go → internal/experiment/webconnectivitylte/redirects.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 import "sync/atomic"
 

internal/experiment/webconnectivity/secureflow.go → internal/experiment/webconnectivitylte/secureflow.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // SecureFlow

internal/experiment/webconnectivity/summary.go → internal/experiment/webconnectivitylte/summary.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // Summary

internal/experiment/webconnectivity/testkeys.go → internal/experiment/webconnectivitylte/testkeys.go

@@ -1,4 +1,4 @@
-package webconnectivity
+package webconnectivitylte
 
 //
 // TestKeys for web_connectivity.

internal/registry/webconnectivityv05.go

@@ -7,18 +7,18 @@ package registry
 //
 
 import (
-	"github.com/ooni/probe-cli/v3/internal/experiment/webconnectivity"
+	"github.com/ooni/probe-cli/v3/internal/experiment/webconnectivitylte"
 	"github.com/ooni/probe-cli/v3/internal/model"
 )
 
 func init() {
 	AllExperiments["web_connectivity@v0.5"] = &Factory{
 		build: func(config any) model.ExperimentMeasurer {
-			return webconnectivity.NewExperimentMeasurer(
-				config.(*webconnectivity.Config),
+			return webconnectivitylte.NewExperimentMeasurer(
+				config.(*webconnectivitylte.Config),
 			)
 		},
-		config:        &webconnectivity.Config{},
+		config:        &webconnectivitylte.Config{},
 		interruptible: false,
 		inputPolicy:   model.InputOrQueryBackend,
 	}

script/gorenamepkg.bash

@@ -0,0 +1,36 @@
+#!/bin/bash
+set -euo pipefail
+
+if [[ $# -ne 2 ]]; then
+	echo "usage: $0 {name-before} {name-after}" 1>&2
+	exit 1
+fi
+name_before=$1
+shift
+name_after=$1
+shift
+
+basename_before=$(basename $name_before)
+basename_after=$(basename $name_after)
+
+echo "git mv $name_before $name_after"
+git mv $name_before $name_after
+
+for file in $(find $name_after -type f -name \*.go); do
+	echo "replacing the package name of $file"
+	cat $file | sed -e "s|^package $basename_before|package $basename_after|g" \
+		-e "s|^// Package $basename_before|// Package $basename_after|g" > $file.tmp
+	cat $file.tmp > $file
+	rm $file.tmp
+done
+
+pkg_prefix=github.com/ooni/probe-cli/v3
+pkg_before=$pkg_prefix/$name_before
+pkg_after=$pkg_prefix/$name_after
+
+for file in $(find . -type f -name \*.go); do
+	echo "editing the import path of $file"
+	cat $file | sed -e "s|\"$pkg_before\"|\"$pkg_after\"|g" > $file.tmp
+	cat $file.tmp > $file
+	rm $file.tmp
+done