Use ~/.ooniprobe as the home directory #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all probe-legacy related to code since there is no more conflict between the two Fixes: ooni/probe#972
bassosimone
approved these changes
Jan 27, 2020
.gitignore
Outdated
| @@ -1,6 +1,7 @@ | |||
| /dist | |||
| /ooniprobe | |||
| /coverage.cov | |||
| /ooni.cov | |||
There was a problem hiding this comment.
Why do we have two differently named files for coverage?
There was a problem hiding this comment.
I suspect coverage.cov is how it used to be called at some point in the past. Maybe we should look into dropping that one from the .gitignore or maybe just do .gitignore for *.cov?
There was a problem hiding this comment.
I am confused by what I see, tho:
sbs@synchronicity probe-cli % git grep ooni.cov
sbs@synchronicity probe-cli % git grep coverage.cov
.gitignore:/coverage.cov
build.sh: $0 __docker go test -v -coverprofile=coverage.cov -coverpkg=./... ./...
build.sh: -coverprofile=coverage.cov -service=travis-ci
build.sh: go test -v -race -coverprofile=coverage.cov -coverpkg=./... ./...
sbs@synchronicity probe-cli % git branch
* issue/973
masterThere was a problem hiding this comment.
(issue/973 is branched off the current master)
There was a problem hiding this comment.
probe-cli [fix/ooni_home] % ls -l ooni.cov
-rw-r--r-- 1 x staff 16043 Dec 2 14:17 ooni.cov
Hum ok, maybe this was an old file I had lying around from a time prior to some refactor?
|
I'm going to squash and merge (need to merge another PR soon and tag a release). |
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
* Use ~/.ooniprobe as the home directory Remove all probe-legacy related to code since there is no more conflict between the two Fixes: ooni/probe#972 * Update .gitignore Co-authored-by: Simone Basso <bassosimone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all probe-legacy related to code since there is no more conflict
between the two
Fixes: ooni/probe#972