Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly handle SIGINT #106

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Explicitly handle SIGINT #106

merged 1 commit into from
Feb 10, 2020

Conversation

hellais
Copy link
Member

@hellais hellais commented Feb 7, 2020

Tentative fix for: ooni/probe#1005

@hellais hellais mentioned this pull request Feb 7, 2020
Closed
@bassosimone
Copy link
Contributor

Tomorrow I should be able to test on Windows.

@hellais
Copy link
Member Author

hellais commented Feb 10, 2020

@bassosimone also check the backlog of the #ooni-probe channel. @sarathms did some debugging of this issue on windows too.

@sarathms
Copy link
Contributor

From what I tried, the probe-cli part of the interaction works fine on Windows. I am able to run a test and do a 'Ctrl+C' which gets caught and initiates a clean shutdown. The part that fails is probe-desktop doing the equivalent of a Ctrl+C because child_process.kill('SIGINT') doesn't generate the expected signal on Windows.

sarathms
sarathms approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@sarathms sarathms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@hellais hellais merged commit f8a49c9 into master Feb 10, 2020
@hellais hellais deleted the signal-windows branch February 10, 2020 16:38
ainghazal pushed a commit to ainghazal/probe-cli that referenced this pull request Mar 8, 2022
@hellais
Merge pull request ooni#106 from ooni/signal-windows
8102245 
Explicitly handle SIGINT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarathms sarathms sarathms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hellais @bassosimone @sarathms