signal: remove check for api.directory.signal.org #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoncpu
referenced
this pull request
in signalapp/Signal-TLS-Proxy
May 7, 2023
|
Thank you, I will include this PR into the next release |
bassosimone
changed the title
bassosimone
pushed a commit
that referenced
this pull request
May 10, 2023
The reference to the `api.directory.signal.org` domain was removed in signalapp/Signal-TLS-Proxy@461d2d1, so the check for Signal fails. This commit removes the reference to the domain in OONI Probe as well.
bassosimone
added a commit
that referenced
this pull request
May 31, 2023
We should have bumped it in #1135 but we forgot. Let's do it now for the release/3.17 branch.
cyBerta
pushed a commit
to cyBerta/probe-cli
that referenced
this pull request
Aug 4, 2023
The reference to the `api.directory.signal.org` domain was removed in signalapp/Signal-TLS-Proxy@461d2d1, so the check for Signal fails. This commit removes the reference to the domain in OONI Probe as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference to the
api.directory.signal.orgdomain was removed in signalapp/Signal-TLS-Proxy@461d2d1, so the check for Signal fails. This commit removes the reference to the domain in OONI Probe as well.