feat: start merging filtering into testingx #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To continue rewriting Jafar based tests to use netemx, the next step is to adapt the proxies used by Jafar to be usable from within netemx to implementing equivalent test cases. In turn, netemx is using testingx for general-purpose test servers that could also be interesting for other packages. We also have the netxlite/filtering package, which is ~fine but has a string-based API, where an interface-based API would be more proper and easier to compose. (We historically use a string-based API there because we previously attempted to replace Jafar with code in userspace usinf netxlite/filtering.) The first step in this quest is therefore to rewrite the DNS code inside netxlite/filtering to belong to testingx. Part of ooni/probe#1803.
bassosimone
commented
Sep 5, 2023
bassosimone
commented
Sep 5, 2023
bassosimone
changed the title
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#1803 - [x] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: N/A - [x] if you changed code inside an experiment, make sure you bump its version number: N/A ## Description To continue rewriting Jafar based tests to use netemx, the next step is to adapt the proxies used by Jafar to be usable from within netemx to implement equivalent test cases. In turn, netemx is using testingx for general-purpose test servers that could also be interesting for other packages. We also have the netxlite/filtering package, which is ~fine but has a string-based API, where an interface-based API would be more proper and easier to compose. (We historically use a string-based API there because we previously attempted to replace Jafar with code in userspace usinf netxlite/filtering.) The first step in this quest is therefore to rewrite the DNS code inside netxlite/filtering and move it to testingx. While there rename netemx.UDPResolverFactory to DNSOverUDPServerFactory for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
To continue rewriting Jafar based tests to use netemx, the next step is to adapt the proxies used by Jafar to be usable from within netemx to implement equivalent test cases.
In turn, netemx is using testingx for general-purpose test servers that could also be interesting for other packages.
We also have the netxlite/filtering package, which is ~fine but has a string-based API, where an interface-based API would be more proper and easier to compose. (We historically use a string-based API there because we previously attempted to replace Jafar with code in userspace usinf netxlite/filtering.)
The first step in this quest is therefore to rewrite the DNS code inside netxlite/filtering and move it to testingx.
While there rename netemx.UDPResolverFactory to DNSOverUDPServerFactory for consistency.