cleanup: remove jafar and the previous QA framework #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 7, 2023
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#1803 - [x] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: N/A - [x] if you changed code inside an experiment, make sure you bump its version number: N/A ## Description This is the final act of the quest to replace Jafar. Let's remove Jafar itself and the QA framework using it. We now have a much better QA framework, that runs for each commit, is faster, and allows to better emulate censorship cases. While working on the removal, I noticed some tutorials depended on a limited set of Jafar functionality, namely the possibility of provoking simple censorship conditions. So, I refactored the previous code for managing iptables on Linux used by Jafar to produce a much slimmer, fully unit tested tool implementing a subset of the original CLI. By implementing this change, we make sure that we still have simple ways for people to learn while reading tutorials. What remains to be done at this point is to update existing issues, close done issues, and generally make sure we explain clearly what we achieved by working on this quest, and what new features are now available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This is the final act of the quest to replace Jafar. Let's remove Jafar itself and the QA framework using it. We now have a much better QA framework, that runs for each commit, is faster, and allows to better emulate censorship cases.
While working on the removal, I noticed some tutorials depended on a limited set of Jafar functionality, namely the possibility of provoking simple censorship conditions. So, I refactored the previous code for managing iptables on Linux used by Jafar to produce a much slimmer, fully unit tested tool implementing a subset of the original CLI.
By implementing this change, we make sure that we still have simple ways for people to learn while reading tutorials.
What remains to be done at this point is to update existing issues, close done issues, and generally make sure we explain clearly what we achieved by working on this quest, and what new features are now available.