fix(minipipeline): set control expectation for all observations #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now, we were setting the control expectation (i.e., the final result of accessing the website from the control) only for TCP endpoints observations. However, there are cases where we're considering DNS lookup failures where we also need this information. So, let's just make sure every observation we produce knows about what's the final expectation according to the test helper. Part of ooni/probe#2634
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
…#1419) Up until now, we were setting the control expectation (i.e., the final result of accessing the website from the control) only for TCP endpoints observations. However, there are cases where we're considering DNS lookup failures where we also need this information. So, let's just make sure every observation we produce knows about what's the final expectation according to the test helper. Part of ooni/probe#2634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, we were setting the control expectation (i.e., the final result of accessing the website from the control) only for TCP endpoints observations. However, there are cases where we're considering DNS lookup failures where we also need this information.
So, let's just make sure every observation we produce knows about what's the final expectation according to the test helper.
Part of ooni/probe#2634