Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor changes before alpha release #1601

Merged
merged 3 commits into from
May 14, 2024
Merged

chore: minor changes before alpha release #1601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dca06af
fix(tlsmiddlebox): gofmt -s -w
bassosimone May 14, 2024
b1eaaca
fix(docs/releasing.md): correct typo
bassosimone May 14, 2024
c84186c
x
bassosimone May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/releasing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ version that is compatible with our dependencies.
We should additionally update the `toolchain` line inside of `go.mod` to use the
specific toolchain we want to use. (The `toolchain` mechanism was introduced by
Go 1.21.0 and it may be that we can now use just the `toolchain` instead of
using the `GOVERSIOn` file; this should eventually be investigated.)
using the `GOVERSION` file; this should eventually be investigated.)

After updating `GOVERSION` and `go.mod`, we need to update our stdlib forks:

Expand Down
2 changes: 1 addition & 1 deletion internal/experiment/tlsmiddlebox/syscall_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ package tlsmiddlebox

import (
"net"
"syscall"
"strings"
"syscall"
)

// SetTTL sets the IP TTL field for the underlying net.TCPConn
Expand Down
2 changes: 1 addition & 1 deletion internal/experiment/tlsmiddlebox/syscall_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ package tlsmiddlebox

import (
"net"
"syscall"
"strings"
"syscall"
)

// SetTTL sets the IP TTL field for the underlying net.TCPConn
Expand Down
3 changes: 0 additions & 3 deletions internal/webconnectivityalgo/calltesthelpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,6 @@ func TestSessionCallWebConnectivityTestHelper(t *testing.T) {
})

t.Run("with two test helpers where the first one times out the connection and the second works", func(t *testing.T) {
// TODO(bassosimone): the utility of this test will become more obvious
// once we switch this specific test to using httpclientx.

// create a local test server1 that resets the connection after a ~long delay
server1 := testingx.MustNewHTTPServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
select {
Expand Down
Loading