Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/2722i #1606

Closed
wants to merge 7 commits into from
Closed

Issue/2722i #1606

wants to merge 7 commits into from
+20 −6

Conversation

bassosimone
Copy link
Contributor

Checklist

  • I have read the contribution guidelines
  • reference issue for this pull request:
  • if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request:
  • if you changed code inside an experiment, make sure you bump its version number

Description

Please, insert here a more detailed description.

@bassosimone
Copy link
Contributor Author

I opened this PR to understand failures in netemx related test cases when adding ReadHeaderTimeout. It seems these issues are related to adding a timeout and using netemx. It is not fully clear to me why, for now. Anyway, we can close this PR, since working on #1603 will be enough.

@bassosimone bassosimone deleted the issue/2722i branch May 14, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais will be requested when the pull request is marked ready for review hellais is a code owner

@DecFox DecFox Awaiting requested review from DecFox DecFox will be requested when the pull request is marked ready for review DecFox is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bassosimone