refactor(webconnectivity): use engine.InputLoader #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff pins to ooni/probe-engine@3049779 and starts using the recently introduced probe-engine APIs. Namely, here, we use the InputLoader for loading URLs. I've confirmed manually everything is still working as intended. Part of ooni/probe#1283. (In particular, the InputLoader is the abstraction allowing us to load input from several sources, including command line flags and external files.)
|
Merging: the macos build has been building for more than twenty minutes now without any output on the console. I stopped it and restarted it and again there was no output on the console. I'm going to flag this as a GHA glitch. |
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
This diff pins to ooni/probe-engine@3049779 and starts using the recently introduced probe-engine APIs. Namely, here, we use the InputLoader for loading URLs. I've confirmed manually everything is still working as intended. Part of ooni/probe#1283. (In particular, the InputLoader is the abstraction allowing us to load input from several sources, including command line flags and external files.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff pins to ooni/probe-engine@3049779
and starts using the recently introduced probe-engine APIs.
Namely, here, we use the InputLoader for loading URLs.
I've confirmed manually everything is still working as intended.
Part of ooni/probe#1283.
(In particular, the InputLoader is the abstraction allowing us to load
input from several sources, including command line flags and external
files.)