feat(cli/run): read inputs from file/cmdline #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff introduces the possibility of specifying --input-file file multiple times to force ooniprobe to read inputs from file. Like we do for miniooni, the file shall contain a single entry per line and this entry should be a URL for websites. Likewise, one can specify --input URL multiple times. This implementation is a very simple, initial implementation and there is a bunch of changes I'd like to add on top of it. And also perhaps a bunch of cleanups. I've chosen to expose these flag _only_ for websites for now. Part of ooni/probe#1283.
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
This diff introduces the possibility of specifying --input-file file multiple times to force ooniprobe to read inputs from file. Like we do for miniooni, the file shall contain a single entry per line and this entry should be a URL for websites. Likewise, one can specify --input URL multiple times. This implementation is a very simple, initial implementation and there is a bunch of changes I'd like to add on top of it. And also perhaps a bunch of cleanups. I've chosen to expose these flag _only_ for websites for now. Part of ooni/probe#1283.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff introduces the possibility of specifying --input-file file
multiple times to force ooniprobe to read inputs from file.
Like we do for miniooni, the file shall contain a single entry per
line and this entry should be a URL for websites.
Likewise, one can specify --input URL multiple times.
This implementation is a very simple, initial implementation and there
is a bunch of changes I'd like to add on top of it.
And also perhaps a bunch of cleanups.
I've chosen to expose these flag only for websites for now.
Part of ooni/probe#1283.