fix: import path should be github.com/ooni/probe-cli/v3 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to go modules rules, this is the place where the sources for version 3 should actually be living. The only change with respect to the original sources has been that I have change the go module and all the import paths.
This starts to make space for merging probe-engine into this repository. We going to do this as part of internal.
We will need to refactor a bunch of directories and make sure we are correctly running all the tests. We need to include probe-engine as internal because we cannot make API promises with it. The only changes with respect to the original release are that I have merged the go.mod into v3/go.mod and that I have changed all the import paths accordingly.
While there, hide unexported actions and further split actions such that they can be invoked from many systems.
First we want a reasonable small diff to land where we have just arranged for probe-cli to be inside v3.
We don't need to concern ourselves about running go mod tidy now since go.mod has been moved into ./v3.
bassosimone
changed the title
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ooni/probe#1335 (comment)