Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor dns implementation in measurexlite #857

Merged
merged 5 commits into from Aug 11, 2022
Merged

feat: refactor dns implementation in measurexlite #857

merged 5 commits into from Aug 11, 2022

Conversation

DecFox
Copy link
Collaborator

@DecFox DecFox commented Aug 11, 2022

Checklist

Description

  • This diff replaces the DNSLookup buffer to use a simple buffered channel instead of a query-based map
  • It also replaces the anonymous resolver initializing functions to use a simpler, wrapResolver

@DecFox DecFox changed the title Dns measurexlite feat: refactor dns implementation in measurexlite Aug 11, 2022
bassosimone
bassosimone approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐳

internal/measurexlite/dns_test.go Outdated Show resolved Hide resolved
internal/engine/experiment/dnsping/dnsping.go Outdated Show resolved Hide resolved
@bassosimone bassosimone merged commit fc51590 into ooni:master Aug 11, 2022
@DecFox DecFox deleted the dns-measurexlite branch August 12, 2022 05:09
@DecFox DecFox mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@DecFox @bassosimone