feat: context-based tracing to record delayed DNS responses #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DecFox
changed the title
DecFox
changed the title
1. we can use the same function for constructing a new Archival DNS lookup result as long as we abstract over the type passed to the constructor, which only needs to include Address and Network; 2. rename the function to drain from the trace to make it more explicit that we need a timeout using a context; 3. improve documentation of late response callback's args; 4. ensure we own the connection and avoid reporting errors in the sendrecv loop, which we actually don't care of.
Now the caller has to pass a context and a timeout and both concur to decide when to stop reading. Additionally, recognize that channel selection is nondeterministic and make sure we fully drain from the channel if the context expires and the channel still happens to continue to be readable.
bassosimone
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
🐳
Thank you!
(FTR, I pushed some extra changes for correctness and asked @DecFox out of band to check whether my extra changes were okay)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This diff simplifies the existing implementation of the
DNSOverUDPtransport by migrating core functionality to theRoundTripenabling the use of a background routine to record delayed DNS responses. This also allows us to make use of context-based tracing to record delayed responses.